Adjust coverage thresholds after @objectstack 0.9.1 upgrade#372
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…pgrade Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
|
✅ All checks passed!
|
hotlong
merged commit f88605a
into
copilot/update-kernel-to-latest-version
There was a problem hiding this comment.
Pull request overview
This PR adjusts test coverage thresholds in the vitest configuration to accommodate a coverage drop that occurred after upgrading @objectstack dependencies from 0.9.0 to 0.9.1. The current actual coverage is 61.67% for lines and 60.46% for statements, and the thresholds have been lowered from 63%/62% to 61%/60% respectively to prevent CI failures while maintaining coverage enforcement.
Changes:
- Reduced coverage thresholds for lines (63% → 61%) and statements (62% → 60%)
- Added contextual comments documenting the timestamp and reason for the adjustment
| lines: 61, // Actual: 61.67% (was 63%) | ||
| functions: 43, | ||
| branches: 40, | ||
| statements: 62, | ||
| statements: 60, // Actual: 60.46% (was 62%) |
There was a problem hiding this comment.
The coverage thresholds documented in CONTRIBUTING.md are now outdated and inconsistent with the actual thresholds set in vitest.config.mts. The documentation states "Lines: 63%" and "Statements: 62%" (at line 381 and 384), but the actual thresholds have been reduced to 61% and 60% respectively. This inconsistency should be addressed by updating CONTRIBUTING.md to reflect the new threshold values, ensuring developers have accurate information about the current coverage requirements.
CI failing on coverage thresholds after upgrading @objectstack dependencies. Current coverage: 61.67% lines, 60.46% statements.
Changes
vitest.config.mts:Context
The config already documents these should be "adjusted to reflect current coverage levels and prevent CI failures" with a target to gradually increase as test coverage improves.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.